opendefensecloud / solution-arsenal / 34352790107
80%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 94
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.756%. Remained the same
34352790107

push

github

web-flow 
chore(chart): drop unused helm helpers (#797)

## What
Remove two helper definitions from `charts/solar/templates/_helpers.tpl`
that no template includes: `solar.imagePullSecrets` and
`solar.annotations`.

## Why
Both are dead. `solar.annotations` is a wrapper around
`.Values.commonAnnotations`, which the workload templates and
`namespace.yaml` already read directly. `solar.imagePullSecrets` is
worse than merely unused: it emits `- name: {{ . }}` for a list of
strings, while every deployment passes a list of objects through
`toYaml`, so anyone who wired it up would get `name: map[name:foo]` in
the rendered pod spec. Deleting it removes the trap rather than leaving
a second, incompatible way to render the same field.

Found while fixing #768, kept out of that PR to keep the bugfix
reviewable on its own.

## Testing
`helm lint` clean, and `helm template` output is byte-identical before
and after, both with default values and with every list value in
`values.yaml` populated. No test changes — nothing includes the removed
helpers, so there is no behavior to cover.

## Notes for reviewers
`.Values.commonAnnotations` stays, it is consumed directly by
`apiserver`, `controller`, `ui`, `etcd`, and `namespace.yaml`.
Chart-only change, no API, CRD, or RBAC impact.

## Checklist
- [x] ~~Tests added/updated~~ n/a
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Refactor**
* Removed internal Helm chart helper templates for image pull secrets
and annotations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

5815 of 7291 relevant lines covered (79.76%)

29.0 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
73.13
 -2.99% pkg/controller/registrybinding_controller.go
2
88.1
 0.0% pkg/controller/rendertask_controller.go
Jobs
ID Job ID Ran Files Coverage
1 34352790107.1 94
79.76
 GitHub Action Run
Source Files on build 34352790107