opendefensecloud / solution-arsenal / 34345337035
80%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 94
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.756% (+0.03%) from 79.728%
34345337035

push

github

web-flow 
fix(chart): emit valid YAML for multiple discovery registries (#795)

## What
Closes #768

Remove the right trim marker on the `$name` assignment in
`charts/solar-discovery/templates/registries.yaml` so each rendered
`Registry` stays its own YAML document, and add a CI fixture that keeps
it that way.

## Why
The `-}}` consumed the newline preceding the `---` separator, so with
more than one entry under `registries` the last line of one resource and
the separator of the next were joined into `scanInterval: 5m---`. Flux
Helm Controller rejected the release with yaml unmarshal errors.

The existing Helm Lint workflow could not catch this. It templates every
chart with default values, where `registries: []` means the loop never
runs twice, and a lost separator does not fail rendering anyway — helm
merges the two resources into a single document, whose duplicate keys
silently overwrite each other. The broken template rendered one
`Registry` named `zot-render` and both `yq` and a YAML loader accepted
it.

## Testing
New step in `.github/workflows/helm-lint.yaml` renders every
`charts/*/ci/*-values.yaml` fixture and asserts that the number of
rendered `Registry` resources matches the number of configured
registries. Verified locally against both template versions: `OK: 2
Registry resources` with the fix, `Expected 2 Registry resources, got 1`
with the bug reintroduced.

Also swept the remaining templates for the same defect class — a `---`
separator emitted inside a `range` — and rendered both charts with every
list value populated and every `enabled`/`create` toggle flipped. No
other template is affected.

## Notes for reviewers
Chart-only change, no API, CRD, or RBAC impact. No upgrade path needed —
previously the multi-registry case simply failed to apply. `ci/` is
excluded from the packaged chart via `.helmignore`.

The assertion covers registries specifically rather than resource counts
in general, because a merged document parses cleanly and helm repor... (continued)

5815 of 7291 relevant lines covered (79.76%)

28.76 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
88.1
 0.0% pkg/controller/rendertask_controller.go
Jobs
ID Job ID Ran Files Coverage
1 34345337035.1 94
79.76
 GitHub Action Run
Source Files on build 34345337035