bleedingdeacons / hand / 34349258536
93%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 17
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.769% (+0.3%) from 92.465%
34349258536

push

github

web-flow 
feat: show a picked member's phone numbers on the compose screen (#53)

The picker names people it gave no way to phone. A responder who found
somebody in the directory and needed to ring rather than message them
had to go and look the number up somewhere else, which on a handset
mid-shift means not bothering.

Reach now answers for one member at a time on
GET /reach/v1/members/{id}/contact, so this asks per member and only
when the responder presses for it. Not with the list, and not for the
page: Reach writes an audit row against the member for every read and
counts it against an hourly cap, so fetching a page's worth would spend
both on names nobody looked at — and would put the directory's numbers
on the handset wholesale, which is the thing the split exists to
prevent. Same reasoning, and the same shape, as an alert's contact.

The row shows the number the member asked to be rung on first, tagged,
with the other under it. The tag only appears when both numbers are on
file: one number has nothing to be preferred over. A stored preference
for a landline that has since been deleted is ignored rather than
followed into an empty line — Reach keeps the last saved choice for a
field its conditional logic has hidden, so the preference is read
together with the numbers, never on its own.

That ordering lives on HandMember rather than in the layout. Expressing
"the landline, but only when it is not already above" in XAML needs a
condition the markup cannot spell without a converter, and getting it
wrong leaves a blank line in a list rather than anything that looks like
a bug. On the model it is eight assertions instead.

A member Unity holds no number for reads as "no number on file" rather
than offering the button again — a second press would spend another of
the responder's allowance and write another audit row to be told the
same thing.

The numbers are shown, not dialled. Nothing else in this app dials for
the responder — an alert's contact is displaye... (continued)

1360 of 1466 relevant lines covered (92.77%)

1292.24 hits per line

Coverage Regressions

Lines Coverage ∆ File
23
76.24
0.96% Services/ReachClient.cs
Jobs
ID Job ID Ran Files Coverage
1 34349258536.1 17
92.77
GitHub Action Run
Source Files on build 34349258536