FlexMeasures / flexmeasures / 34325410544

85%

push

github

Reject a resolution that spans no positive time (#2502)

* Reject a resolution that spans no positive time (#2493)

`GET /sensors/<id>/data?resolution=PT0S` crashed with an uncaught
`ZeroDivisionError` from pandas, and was reported as a bare 500,
because `DurationField` only rejects durations that are not a multiple
of 1 minute, which a zero duration passes.

Add a `ResolutionField`, which additionally requires the duration to
span a positive amount of time, and use it for every `resolution`
query parameter the API takes.
A negative resolution was accepted too, and quietly described an empty
set of events; it is now rejected the same way.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RgnoDDysWF5CMi3k827rHM
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Reference the PR number in the changelog entry

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RgnoDDysWF5CMi3k827rHM
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Cover the days component of a nominal resolution

An isodate.Duration keeps its days and seconds in its tdelta, and only
its years and months next to it, so checking the tdelta already covers
a duration such as "P1M1D". Say so, and pin it down with tests.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RgnoDDysWF5CMi3k827rHM
Signed-off-by: F.N. Claessen <felix@seita.nl>

* End a test comment at punctuation

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RgnoDDysWF5CMi3k827rHM
Signed-off-by: F.N. Claessen <felix@seita.nl>

* Describe the change accurately in both changelogs

The main entry only mentioned a zero resolution, where a negative one is
rejected too, and the API entry called `resolution` a query parameter,
where the schedule trigger endpoints read it from the request body.

Co-Authored-By: Claude Opus 5 <no... (continued)

15 of 15 new or added lines in 5 files covered. (100.0%)

18490 of 21748 relevant lines covered (85.02%)

0.85 hits per line