FlexMeasures / flexmeasures / 34282089360

85%

push

github

Status page: show every sensor it asks about, and stop asking about fixed-value sensors (#2489)

* Fix status page dropping sensors and asking about fixed-value sensors

The status page asks the status endpoint about each sensor separately and
collects the answers. A failing request used to be counted twice, because both
the "error" and the "complete" handler counted it, so the table was handed over
before the slower requests had come back — which sensors made it onto the page
then depended on which ones answered first.

The collecting is now a module of its own, fetchSensorStatuses, which waits for
every request and reports the sensors in the order they were given, so a sensor
that cannot be fetched no longer hides the ones that can.

Two of those requests could not succeed in the first place: fixed-value sensors
stand in for flex-config quantities, carry negative IDs and have no row in the
database, so they are no longer listed as sensors to report connectivity for.

Fixes #2478

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Add changelog entry for the status page fix

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* Keep the status page script classic, so its tables build first

Making the script a module made it deferred, so it registered its ready handler
after flexmeasures.js registered its own. The generic table setup in
flexmeasures.js then reached both tables first and built them with default
options, and the page's own calls failed as a reinitialisation — DataTables
warned about sensorStatusTable and jobsTable, and neither table had any rows.

The page content is rendered before flexmeasures.js is loaded, so a classic
script here registers first, and the generic setup finds both tables already
built and leaves them alone. sensor-status-utils.js is imported where it is
used instead, which needs no module script.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* black

Signed-off-by: Nicolas Höning <nicolas@seita.nl>... (continued)

2 of 2 new or added lines in 1 file covered. (100.0%)

18480 of 21738 relevant lines covered (85.01%)

0.85 hits per line