Ghini / ghini.desktop / 34323499744

58%

master: 62%

Build Type

push

github

Committed by Mario Frasca

Commit Message

refactor: Avoid Gtk.ListStore/TreeStore positional-arg constructor

Gtk.ListStore(*column_types) / Gtk.TreeStore(*column_types) only work
via a PyGObject override that intercepts the constructor; plain
GObject.Object.__init__() itself accepts no positional arguments.
Surfaced on the Windows build (PyGObject 3.56.3 via gvsbuild, vs 3.50.0
in the Linux dev venv):

    TypeError: GObject.__init__() takes exactly 0 arguments (1 given)

Replace all 42 call sites (18 files) with the explicit, override-
independent form: Gtk.ListStore()/Gtk.TreeStore() followed by
set_column_types(...). Works the same regardless of PyGObject version
or platform.

One test file (test_gtk_smoke.py) keeps a small local
_new_list_store() helper where the constructor call is nested inside
another expression and can't be split into two statements.

Test suite run locally, passes.

Coverage Stats

41 of 65 new or added lines in 15 files covered. (63.08%)

232 existing lines in 2 files now uncovered.

13074 of 22371 relevant lines covered (58.44%)

0.58 hits per line