decentraland / lamb2 / 34224938522

74%

push

github

fix: refresh owned elements every minute, serving stale only within a bounded grace window (#482)

* fix: serve owned elements at most a minute old, refreshing stale entries in the background

The elements cache kept an address's inventory for ten minutes, and profile
validation checks worn items against it, so a wearable bought and equipped a
moment ago was stripped from the avatar until the entry expired; the registry
then persisted that stripped profile. The age was also a hardcoded constant.

Entries now default to one minute (ELEMENTS_CACHE_MAX_AGE, with
ELEMENTS_CACHE_MAX_SIZE alongside) and are served stale while a single
background refresh runs, which fetchMethod makes possible: a hot address costs
one upstream fetch per minute however often it is polled, and nobody waits on
the refresh. The legacy lands fetcher keeps its previous behaviour.

* fix: keep linked wearables cached for ten minutes

Filling a linked-wearables entry asks the NFT worker for the wallet's tokens
across every registered contract and then the content server for the matching
collections, and those tokens change rarely. Their presence on a profile is
validated per item through the ownership checker rather than through this
cache, so a longer age costs no correctness there. The fetcher keeps the
previous ten minutes through THIRD_PARTY_WEARABLES_CACHE_MAX_AGE while the
other owned-element caches move to one minute.

* fix: fail closed on ownership routes and meter the elements cache

Serving stale was on for every fetcher, including the two whose answer decides
ownership: the name owner and land permission lookups. On an outage those
would have answered with the previous owner for one refresh window instead of
failing. Stale serving is now a per-fetcher option and off for both, so an
expired entry blocks on the refresh and an upstream failure surfaces.

The cache was also invisible. Reads are counted by what they cost (hit, stale,
miss) and background refreshes by outcome; ... (continued)

653 of 1032 branches covered (63.28%)

Branch coverage included in aggregate %.

40 of 44 new or added lines in 2 files covered. (90.91%)

2008 of 2544 relevant lines covered (78.93%)

80.86 hits per line