decentraland / lamb2 / 34166135629

74%

main: 74%

Pull #482

github

fix: bound how long an expired entry may be served while refreshing

Serving stale had no upper bound: lru-cache keeps an idle entry until it is
evicted, so the first read of an address not seen for hours was answered with
that hours-old inventory while the refresh ran, which undoes the freshness
this change is for.

An expired entry is now served only within ELEMENTS_CACHE_MAX_STALE_AGE
(default one minute) past its age; beyond that the read blocks on a fresh
fetch through a per-call allowStale of false. Reads and refreshes are
classified from that per-call decision, so a blocking refresh of an over-age
entry is a miss rather than a background refresh.

597 of 1032 branches covered (57.85%)

Branch coverage included in aggregate %.

40 of 44 new or added lines in 2 files covered. (90.91%)

1946 of 2544 relevant lines covered (76.49%)

80.4 hits per line