zalando-incubator / kube-ingress-aws-controller / 34150637964

71%

master: 71%

Pull #815

github

subnets: add subset to same AZ can lead to stack UPDATE_FAILED state

AWS fail to update stack with

```
This AWS::ElasticLoadBalancingV2::LoadBalancer resource is in a UPDATE_FAILED state.

Resource handler returned message: "You cannot specify an additional subnet from an Availability Zone that is already associated with the load balancer. The Availability Zone 'eu-central-1b' corresponding to the new subnet 'subnet-XXXXX' is already associated with the load balancer.
```

Since FindLBSubnets choose the subnet via elb-role tag presense and lexicographically adn have no knowledge about previously chosen subnets
We can choose one subnet for a specific AZ that already have and existing subnet, which AWS will block.

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>

30 of 32 new or added lines in 3 files covered. (93.75%)

2725 of 3812 relevant lines covered (71.48%)

11.43 hits per line