Unleash / unleash / 34130010045

87%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(addons): treat single-character templates as valid in ServiceNow and webhook addons

`crCreationNoteTemplate` (ServiceNow) and `bodyTemplate` (webhook)
rejected any template of length <= 1, so a legitimate one-character
template was silently dropped in favor of the default message. Trim
before checking emptiness so only actually-empty/whitespace-only
templates fall back to the default, while the original (untrimmed)
template is still used for rendering.

Other places with the same `.length > 1` off-by-one (not fixed by this
PR):

- Webhook `customHeaders` —
[oss/src/lib/addons/webhook.ts#L105](https://github.com/bricks-software/unleash-enterprise/blob/main/oss/src/lib/addons/webhook.ts#L105)
- Datadog `bodyTemplate` —
[oss/src/lib/addons/datadog.ts#L66](https://github.com/bricks-software/unleash-enterprise/blob/main/oss/src/lib/addons/datadog.ts#L66)
- Datadog `customHeaders` —
[oss/src/lib/addons/datadog.ts#L83](https://github.com/bricks-software/unleash-enterprise/blob/main/oss/src/lib/addons/datadog.ts#L83)
- New Relic `bodyTemplate` —
[oss/src/lib/addons/new-relic.ts#L65](https://github.com/bricks-software/unleash-enterprise/blob/main/oss/src/lib/addons/new-relic.ts#L65)
- New Relic `customHeaders` —
[oss/src/lib/addons/new-relic.ts#L83](https://github.com/bricks-software/unleash-enterprise/blob/main/oss/src/lib/addons/new-relic.ts#L83)
- Slack `customHeaders` —
[oss/src/lib/addons/slack.ts#L64](https://github.com/bricks-software/unleash-enterprise/blob/main/oss/src/lib/addons/slack.ts#L64)
- Teams `customHeaders` —
[oss/src/lib/addons/teams.ts#L80](https://github.com/bricks-software/unleash-enterprise/blob/main/oss/src/lib/addons/teams.ts#L80)
- Teams Workflow `customHeaders` —
[oss/src/lib/addons/teams-workflow.ts#L98](https://github.com/bricks-software/unleash-enterprise/blob/main/oss/src/lib/addons/teams-workflow.ts#L98)

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

3963 of 5163 branches covered (76.76%)

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

16176 of 18509 relevant lines covered (87.4%)

855.6 hits per line