hyperledger-labs / fabric-smart-client / 34129708560

86%

Build Type

push

github

Committed by web-flow

Commit Message

chore(deps): replace the unmaintained uptrace opentelemetry-go-extra modules (#1753)

FSC depended on three github.com/uptrace/opentelemetry-go-extra modules:
otelzap and otelsql directly, otelutil transitively. Upstream's last commit
is 2024-11-18 and v0.3.2 is its newest tag, so the suite no longer tracks the
OpenTelemetry Go API.

That came due in #1747. go.opentelemetry.io/otel/log v0.21.0 deleted
keyvalue.go, and with it log.Value and every log.XxxValue constructor.
otelutil v0.3.2 still calls them, so bumping otel/log past v0.20.0 stops the
module compiling:

	otelutil@v0.3.2/attribute.go:68:38: undefined: log.Value
	otelutil@v0.3.2/attribute.go:71:14: undefined: log.StringValue

Pinning otel/log at v0.20.0 would work, and would have to hold forever.

otelzap turns out not to be needed at all. It was configured with a
LoggerProvider wrapping noop.NewLoggerProvider(), and spanLogger.Emit
discarded every part of the record it received except the body:

	trace.SpanFromContext(ctx).AddEvent(record.Body().AsString(), ...)

So each context-aware call built a log.Record, set its severity, ran
otelutil.LogValue over the fields -- the code path that needs the removed
API -- and looked up runtime.Caller, and all of it was thrown away to keep one
string. Only two behaviours were ever consumed:

  - span.AddEvent(msg, logger.name=...) at or above the logger's level
  - span.SetStatus(codes.Error, msg) for Error and above

Both are now produced directly in ctxFieldLogger over a plain
zap.SugaredLogger, and the log-signal plumbing -- spanLoggerProvider,
spanLogger, sanitizedSpanLogger -- is gone along with the otel/log dependency
itself. Nothing is computed when the span in ctx is not recording, so
fmt.Sprintf and the sanitizer no longer run on the common untraced path:

	InfowContext, enabled, no fields   before  1378 ns/op  1785 B/op  11 allocs/op
	                                    after   453 ns/op  1221 B/op   3 allocs/op

contrib/bridges/otelzap is not... (continued)

Coverage Stats

39 of 53 new or added lines in 2 files covered. (73.58%)

14 existing lines in 3 files now uncovered.

31332 of 36695 relevant lines covered (85.38%)

2765.78 hits per line