ArduPilot / MethodicConfigurator / 34125351586

90%

push

github

test(acceptance): sort vehicle template discovery for deterministic order

get_vehicle_template_directories() returned templates in raw
Path.iterdir() order, which is filesystem dependent. The two tests that
consume the compounded_params_files fixture only examine the first 5 and
the first 10 discovered templates, so which templates are exercised
depended on the filesystem the tests happened to run on.

On the ubuntu-latest runners iterdir() yields the non-ArduCopter vehicle
types first, so the whole [:5] window landed on ArduPlane, Heli and Rover
templates. get_empty_template_dir() only resolves empty_4.6.x, which
ships for ArduCopter only, so every iteration hit the except/continue
path, all_comparisons stayed empty, and
test_component_inference_from_params_file_matches_original failed with
"No component comparisons were performed". The same commit passed on
macos-latest and windows-latest, where iterdir() happens to yield the
ArduCopter templates first.

Sorting every directory listing by lower-cased name makes discovery
independent of both the filesystem and the platform. Sorting the Path
objects directly would not be sufficient: PurePath comparison is
case-insensitive on Windows but case-sensitive on POSIX, so a plain
sorted() would still select a different window per platform.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: cnYui <xiaobianfuai@gmail.com>

4705 of 5704 branches covered (82.49%)

17004 of 19038 relevant lines covered (89.32%)

2.66 hits per line