Qiskit / qiskit-fermions / 34126153811
98%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 110
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 98.153% (-0.02%) from 98.172%
34126153811

push

github

web-flow 
refactor(linalg)!: remove the double factorization module (#325)

Two removals with the same fate, taken together because they delete from the
same two files and share the same helper types.

The `t2` family (`double_factorized_t2`, `double_factorized_t2_alpha_beta` and
the two `reconstruct_t2*` routines that existed only to verify their
round-trip) lost its last caller when UCJ started taking an ffsim operator:
`_factorize_same_spin` and `_factorize_unbalanced` were the only production
users. `double_factorized_2body`, by contrast, was already dead before this
work and the audit merely surfaced it -- it was exported and tested but called
from nowhere, and it is a subset of ffsim's `linalg.double_factorized`, which
additionally offers the optimized decomposition.

Together they retire the module, so rather than gutting it both source files
are deleted outright: with every public function gone, the shared term aliases
and the private `modified_cholesky` helper lose their last user too. That
helper was never public API (no pyext binding, no Python export), so nothing
needs deprecating on its way out. `linalg` is left exporting only the two
Givens routines, which are genuinely load-bearing for OrbitalRotation and
PrepareSlaterDeterminant synthesis under Jordan-Wigner.

Worth naming as a real cost: these were native Rust with no PySCF dependency,
so a Windows user could exactly double-factorize t2 amplitudes where ffsim's
equivalents are unavailable. Since UCJ itself became ffsim-gated, that user
loses the ansatz regardless, so the loss follows from the earlier commit
rather than from this one.

Refs #318

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

12541 of 12777 relevant lines covered (98.15%)

516206.49 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
99.89
-0.11% crates/core/src/mappers/library/jordan_wigner.rs
Jobs
ID Job ID Ran Files Coverage
1 34126153811.1 110
98.15
GitHub Action Run
Source Files on build 34126153811