hyperledger / fabric-x-committer / 34088332371

90%

main: 90%

Build Type

Pull #810

github

Committed by liran-funaro

Commit Message

[coordinator] Report the dependency graph queue sizes on scrape

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- Replace the dependency graph manager's ticker-based queue monitor with gauges read on scrape, and
  delete the sampler goroutine.
- Gather the two input queues into a receive-only `managerQueues` struct built before the metrics
  that observe them.
- Rename `gdgWaitingTxQueueSize` and `dependentTransactionsQueueSize` to `gdgWaitingTxCount` and
  `dependentTxCount`, since neither is a queue: both count transactions held in the graph's maps and
  stay maintained incrementally.
- Rename the exported `coordinator_dependency_graph_dependent_transactions_queue_size` to
  `coordinator_dependency_graph_dependent_transactions`, for the same reason.
- Reword `coordinator_global_dependency_graph_size`'s help to lead with what it counts.
- Remove the `queue-monitor-sampling-time` config key, whose only reader was the sampler.

#### Additional details (Optional)

Deployed YAML that still sets `queue-monitor-sampling-time` keeps loading, as `v.Unmarshal` ignores
unknown keys.

Dashboard-breaking: `coordinator_dependency_graph_dependent_transactions_queue_size` becomes
`coordinator_dependency_graph_dependent_transactions`. `coordinator_global_dependency_graph_size`
keeps its name, as it never claimed to be a queue.

One of the per-service PRs split out of #736.

#### Related issues

- resolves #771
- related to #730

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #810: [coordinator] Report the dependency graph queue sizes on scrape

Coverage Stats

29 of 29 new or added lines in 5 files covered. (100.0%)

10 existing lines in 6 files now uncovered.

9312 of 10286 relevant lines covered (90.53%)

11242.18 hits per line