pmd / pmd / 772

79%

Build Type

push

github

Committed by web-flow

Commit Message

[java] Fix #6780: NonThreadSafeSingleton checkNonStaticMethods contradicting impl (#6864)

* [java] Fix NonThreadSafeSingleton checkNonStaticMethods contradicting its description (#6780)

checkNonStaticMethods=true (the default) was silently skipping
non-static methods instead of checking them - the exact opposite
of the documented behavior. Inverted the condition so the flag
now matches its Javadoc, and added regression tests covering both
the default (checked) and checkNonStaticMethods=false (skipped)
cases.

* Update NonThreadSafeSingleton.xml for consistency

* Deprecate non-static methods check in NonThreadSafeSingletonRule

Updated the NonThreadSafeSingletonRule to remove the check for non-static methods as it is now always enforced. Added deprecation notice for the ignored property.

* Update NonThreadSafeSingleton.xml test data

* Use constant for "!deprecated" rule property

* Add additional tests

- for suppressing via xpath
- for checkNonStaticFields

* NonThreadSafeSingleton: Improve rule documentation

* Update release notes (#6780, #6864)

* Fix dead links checker

* NonThreadSafeSingleton: Use ASTVariableId instead of field names

This makes sure, we resolve the correct
fields in case of shadowing.

---------

Co-authored-by: dweep <existing1.001@gmail>
Co-authored-by: Andreas Dangel <andreas.dangel@pmd-code.org>

Coverage Stats

19698 of 25798 branches covered (76.35%)

Branch coverage included in aggregate %.

23 of 24 new or added lines in 2 files covered. (95.83%)

2 existing lines in 1 file now uncovered.

42628 of 52680 relevant lines covered (80.92%)

0.82 hits per line