ruby-grape / grape / 34029315262

99%

push

github

Stop reassigning method parameters across lib (#2908)

A parameter reassigned partway through a method means the name documents
one thing in the signature and holds another below it. Every site in
`lib` now binds the derived value to its own local, so a parameter keeps
what the caller passed for the whole method.

Two of them were reassigned to hide a mutation of the argument itself,
and those stop writing into what they were given:

* `Middleware::Formatter#ensure_content_type` merged a Content-Type into
  the response headers Hash in place, then returned it.
* `ParamsScope#process_oneof!` wrote the collected variants back into the
  options Hash from the `requires`/`optional` call site. Now
  `#collected_oneof` returns them and the caller merges.

`Endpoint::Options` is left alone; it is fixed in #2907.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1291 of 1334 branches covered (96.78%)

Branch coverage included in aggregate %.

75 of 75 new or added lines in 16 files covered. (100.0%)

4013 of 4013 relevant lines covered (100.0%)

27137.74 hits per line