PHPOffice / PHPPresentation / 34024560186

94%

push

github

PowerPoint2007 Reader : Reach the package through one accessor (#994)

The reader named `$this->oZip` at nineteen places: once to open the archive
and eighteen times to read a part out of it. Opening now happens in
`openPackage()` and reading in `getFromName()`, so the archive is reached
through two methods rather than from the middle of the parsing code.

Nothing changes about what is read. The reader is simply no longer written
against `ZipArchive` in nineteen places, which is what makes a different
package implementation, or a test double, a matter of those two methods.

20 of 21 new or added lines in 1 file covered. (95.24%)

11320 of 12030 relevant lines covered (94.1%)

71.2 hits per line