PHPOffice / PHPPresentation / 33961851893

94%

push

github

PowerPoint97 Reader : Read past the end of a stream without warning (#995)

* PowerPoint97 Reader : Read past the end of a stream without warning

The structures in a `PowerPoint Document` stream are read until a byte fails
a sanity check, and the zeros the last sector was padded with are what stops
that. `getInt1d()`, `getInt2d()` and `getInt4d()` indexed the string directly,
so a stream that ends without those zeros is read one byte past its end and
raises a warning for every byte of the read, once per structure the parser
walks off the end of.

The three now read through `getBytes()`, which pads a short read with the
zeros the sector would have held. Nothing changes for a stream that carries
its padding; a stream that does not is read to its end and stops there.

* PowerPoint97 Reader : Note the stream read in the changelog

* PowerPoint97 Reader : Take the false a short substr answers before PHP 8

6 of 6 new or added lines in 1 file covered. (100.0%)

11318 of 12028 relevant lines covered (94.1%)

71.2 hits per line