solidjs / solid / 34019030975

72%

main: 89%

push

github

fix(signals): route tracked-effect wakes through the heap; drop the commit-wake arm (#3291)

Replaces 3af0f6b4. A tracked effect is a user-phase callback: it runs beside
user-effect callbacks, is stashed with a transition and runs after its commit,
and never holds anything. Its wake, however, bypassed the heap and was pushed
straight into the user queue at notify time — so a write staged during a
render-effect callback (Portal mount, schedule:true effects) re-ran the effect
in the SAME pass, before that write committed, and nothing re-notified it.

enqueueSub now treats tracked effects like every other subscriber (the special
case is deleted); GlobalQueue._update hands a tracked node's callback to the
user queue instead of recomputing it. The first run rides the heap too, so an
effect created inside a render-effect callback runs after that pass commits.
One run, with the landed value — the arm version re-ran the effect a second
time, which effects are not allowed to do.

Documented gap (pinned): a tracked effect's first run cannot observe a write
landing earlier in the same pass to a signal it has not read yet — it
subscribes in the effect phase. User effects subscribe at creation and do not
share it.

Minified core floor -75 B; two brotli caps ratcheted for layout drift.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

515 of 783 branches covered (65.77%)

Branch coverage included in aggregate %.

764 of 998 relevant lines covered (76.55%)

14.94 hits per line