solidjs / solid / 34017882910

72%

main: 89%

push

github

fix(web): freeze response head before disposing an awaited renderToStream (#3292)

`await renderToStream(...)` resolved AFTER disposing the render owner,
while `event.response` was still uncommitted, so every scope-tied
`httpStatus`/`httpHeader` cleanup retracted its declaration before the
consumer ever saw the HTML: a page's `httpStatus(404)` came back 200 from
`createSSRResponse(html, event)` and declared headers vanished. The pipe
paths never hit this because `createSSRResponse` commits the stub on the
shell's first write, before the final dispose.

Treat completion as the awaited path's head-freeze point: the thenable
commits the request's response stub (captured at render start — the
thenable may be awaited outside the request scope it was started in)
right before `dispose()`. `createSSRResponse` / `commitEventResponse`
already pass an already-committed stub through untouched. Retraction
semantics are unchanged — a scope disposed mid-render still retracts —
and the failRender resolution path keeps the head open as before.

Integrations no longer need the `onCompleteAll` commit workaround.

515 of 783 branches covered (65.77%)

Branch coverage included in aggregate %.

764 of 998 relevant lines covered (76.55%)

14.95 hits per line