microlinkhq / browserless / 34017029944

80%

push

github

fix(errors): treat Target closed as context disconnect (#913)

* fix(errors): treat Target closed as context disconnect

Runtime.evaluate / callFunctionOn Target closed is the same teardown as
Session closed. ensureError was labeling it EPROTOCOL instead of
EBRWSRCONTEXTCONNRESET, so callers saw a protocol fault for a dead page.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(errors): keep Target closed from stalling in-place retry

Protocol Target closed is context loss for withPage, but screenshot
wait-and-retry must fail fast — the page is gone, not mid-navigation.
Ignore Evaluation failed: Target closed so page exceptions stay EINVALEVAL.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

936 of 1136 branches covered (82.39%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 2 files covered. (100.0%)

4536 of 5749 relevant lines covered (78.9%)

87159.46 hits per line