jhillyerd / enmime / 33986100358

87%

main: 87%

Build Type

Pull #413

github

Committed by jhillyerd

Commit Message

Add MaxMIMEParts option to cap parsed MIME parts

Messages with a huge number of (possibly tiny) sibling parts could consume
excessive CPU and memory while parsing: every part was materialized with no
part-count limit, and appending each child re-walked the sibling chain,
making part insertion quadratic in the number of parts.

- Add the MaxMIMEParts parser option (default 10000, zero or negative
  disables), enforced by a budget shared across nested multipart parsing.
  Exceeding it aborts parsing with a TooManyPartsError, which is always
  fatal even when SkipMalformedParts is enabled, since the part tree would
  be incomplete.
- Track the tail of each child chain in parseParts via the new appendChild
  helper so appends are O(1) instead of walking the sibling list; AddChild
  delegates to it, preserving its public behavior.

Pull Request Pull Request #413: Add MaxMIMEParts option to cap parsed MIME parts

Coverage Stats

50 of 52 new or added lines in 3 files covered. (96.15%)

19 existing lines in 1 file now uncovered.

3383 of 3895 relevant lines covered (86.85%)

4353.78 hits per line