CyclopsMC / IntegratedTunnels / 33983618546

71%

push

github

Fix flaky testItemsInterfaceTargetPlacedLater game test

The test asserted the exported item exactly TICKS_TRANSFER ticks after
enabling the exporter. When the exporter's first attempts run before the
network has observed the container that just joined it, nothing is moved,
and TunnelHelpers puts the connection to sleep after
GeneralConfig.inventoryUnchangedTickCount failures.

That sleep lives in a Guava cache with expireAfterWrite, so it expires on
wall-clock time (~650ms by default) rather than on ticks. The game test
server overrides waitUntilNextTick to not wait at all, so it ticks far
faster than 20 TPS, and those 650ms can span several hundred ticks, well
past the 100-tick assertion window.

Measured on the current head with the test isolated in its own batch
(fastest ticks, the worst case): the transfer completes at test tick 43
when no sleep kicks in, and at 185-369 when it does. Every run of the old
test in that configuration failed, while 20 runs of the new one passed.

Wait for the transfer instead of asserting after a fixed number of ticks,
like the other transfer tests in this class already do.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013fmCwEgvp2MgAx5ZoFZrFu

620 of 1688 branches covered (36.73%)

Branch coverage included in aggregate %.

5891 of 7521 relevant lines covered (78.33%)

4.07 hits per line