fyne-io / fyne / 33981159997

59%

Build Type

push

github

Committed by andydotxyz

Commit Message

Draw a raster from the top left of its image bounds

NewRasterFromImage was treating the origin of the source image bounds as
a position on the canvas object. An image cut out of a sprite sheet, or
one built with image.NewRGBA(image.Rect(150, 200, 300, 400)), was drawn
shifted by Bounds().Min - or not drawn at all when the raster happened
to be exactly the size of the image, as the painter then read from
pixels that are outside the source.

Where the two did not overlap at all the generator returned an
image.Uniform, whose infinite bounds panic the software scaler. It now
always returns the destination it allocated, so the uncovered area is
the zero pixels that image was made with.

Fixes #6461

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

23351 of 39270 relevant lines covered (59.46%)

704.46 hits per line