aio-libs / multidict / 33972388218

87%

push

github

Fix self-extension without temporary allocations (#1414)

<!-- Thank you for your contribution! -->

## What do these changes do?

Fixed self-extension by reserving capacity and appending the original
internal entries directly. This avoids creating an items view, a
temporary list, or a copied multidict. Based on the original fix by
@cananoo in aio-libs/multidict#1402.

## Are there changes in behavior for the user?

Yes. Extending a multidict with itself or a proxy to itself no longer
crashes.

## Is it a substantial burden for the maintainers to support this?

No. The fast path is contained in the existing hash-table implementation
and is covered for both backends.

## Related issue number

Fixes #1398
Supersedes aio-libs/multidict#1402

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Copilot App 1.0.83-5; reviewed by asvetlov.

---------

Co-authored-by: Min Peng <2059997196@qq.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

627 of 1254 branches covered (50.0%)

Branch coverage included in aggregate %.

22 of 23 new or added lines in 2 files covered. (95.65%)

4032 of 4207 relevant lines covered (95.84%)

1.92 hits per line