aio-libs / multidict / 33970523258

87%

push

github

Fix repeated multidict initialization leak (#1412)

<!-- Thank you for your contribution! -->

## What do these changes do?

Fixed the C extension to release an existing table before replacing it
during repeated initialization. The fast clone path now receives the
supplied mapping and handles self-initialization correctly.

## Are there changes in behavior for the user?

Yes. Reinitializing a C-extension ``MultiDict`` or ``CIMultiDict`` no
longer retains the replaced values. Initialization from a matching
multidict, including itself, now preserves its entries.

## Is it a substantial burden for the maintainers to support this?

No. The change uses the existing table cleanup path and adds coverage
for direct, clone, and self initialization.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` N/A, already listed
- [x] Add a new news fragment into the `CHANGES/` folder

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: C extension, 1665 passed. Pure Python, 852 passed with 813
C-extension cases deselected.

Documentation spelling: the new fragment passed; the target remains
blocked by five existing misspellings in `CHANGES.rst`.
</details>

Drafted with GitHub Copilot App 1.0.83-5; reviewed by @asvetlov.

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

622 of 1244 branches covered (50.0%)

Branch coverage included in aggregate %.

13 of 16 new or added lines in 1 file covered. (81.25%)

4010 of 4184 relevant lines covered (95.84%)

1.92 hits per line