ruby-grape / grape / 33958239245

99%

Build Type

push

github

Committed by web-flow

Commit Message

Make ErrorFormatter.formatter_for a lookup and move the fallback to its caller (#2902)

`formatter_for` took the API's `default_error_formatter` as a third argument
and ended in `default_error_formatter || Grape::ErrorFormatter::Txt`, so the
global registry implemented the caller's precedence with the caller's own
state. It was the only registry that did: `Parser.parser_for` answers nil and
lets the caller decide, `Formatter.formatter_for` falls back to a constant of
its own, and `ParamsBuilder.params_builder_for` raises.

Give it the `Parser.parser_for` shape — API registrations, then the registry,
then nil — and let `Middleware::Error` apply the fallback it owns, defaulting
`default_error_formatter` to `ErrorFormatter::Txt` in its `Options` alongside
`rescue_options` (both arrive as an explicit nil from
`Endpoint#error_middleware_options`, which bypasses the keyword defaults).

Resolution is unchanged, precedence included: a formatter registered for the
requested format still wins over the API's `default_error_formatter`, which
applies to formats that have none of their own.

Reporting the miss also lets the DSL see it. `default_error_formatter` names an
error formatter, so a name nothing is registered under now raises
`Grape::Exceptions::UnknownErrorFormatter` rather than storing the `Txt` the
lookup used to substitute, which read back as a working setting. `format` names
a format, where having no error formatter of its own is ordinary, so it still
succeeds and stores nil, with the middleware supplying `Txt` at render time.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

1240 of 1330 branches covered (93.23%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 4 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

3943 of 4007 relevant lines covered (98.4%)

27183.28 hits per line