ruby-grape / grape / 33920012157

97%

push

github

Cut per-request work out of the endpoint, validation and router paths (#2895)

* Cut per-request work out of the endpoint, validation and router paths

Six independent hot-path changes, none of which alters behaviour: the
response of a 77-case request matrix (versions, formats, validation errors,
nested and array params, `given`, splats, cascade, auto-OPTIONS/405,
percent-encoded paths) is byte-identical to master.

The router found the matching alternative of its compiled union by capture
*name*: one `MatchData#[]` per registered route, each resolving a String
through the pattern's name table. Group numbers index the match region
directly. They are a property of the union rather than of a route's own
pattern -- every route ahead of it contributes however many groups its
pattern declares -- so `compile!` reads `named_captures` once per union and
writes each route's number back through `resolve_capture_group!`.

`AttributesIterator#each` wrapped the scope's params in an Array for
`#do_each` to unwrap on its only iteration. A scope resolves to a Hash unless
the declaration nests arrays, and then neither the nesting descent nor the
index bookkeeping applies, so it yields the Hash straight to
`yield_attributes`. `SingleAttributeIterator` asks `empty?` once for the
attribute list rather than once per attribute; the answer does not depend on
the attribute and costs a `respond_to?`.

`CoerceValidator#validate_param!` read `params[attr_name]` three times --
through a `HashWithIndifferentAccess` key conversion each time -- although
`coerce_value` only ever sees the value. `PrimitiveCoercer` resolves the
input classes Virtus refused (`REJECTED_INPUTS`) and `type != String` in its
constructor rather than re-deriving them from `type` for every value.
`Validators::Base#validate` reads `request.params` once.

`Middleware::Formatter` reads `default_format`, `format`, `formatters` and
`parsers` off ivars assigned in `#initialize` instead of delegating into the
frozen... (continued)

1245 of 1339 branches covered (92.98%)

Branch coverage included in aggregate %.

32 of 32 new or added lines in 9 files covered. (100.0%)

3961 of 4030 relevant lines covered (98.29%)

27045.19 hits per line