adobe / spectrum-web-components / 33914195521

96%

push

github

fix(combobox, breadcrumbs): propagate lang/dir for a single item's language without breaking layout (#6496)

* fix(combobox, breadcrumbs): propagate lang/dir for a single item's language without breaking layout

Previously, setting `lang`/`dir` on a slotted `<sp-menu-item>` (Combobox)
or `<sp-breadcrumb-item>` (Breadcrumbs) had no effect on the rendered
popover/overflow-menu counterpart, since both components synthesize new
elements from extracted data rather than reusing the originals.

- Combobox: forwards `lang`/`dir` from slotted items (or `.options` data)
  onto the rendered popover `<sp-menu-item>`, and now syncs the input's
  own `lang` to the committed option's language for correct pronunciation.
- Breadcrumbs: same propagation for the "More items" overflow menu.
- BreadcrumbItem: forwards `lang`/`dir` to `#item-link` only, so a single
  item's language does not flip its own layout or its separator's
  mirrored chevron. The separator now explicitly tracks the *ambient*
  direction (nearest ancestor `dir`, or the document default) instead of
  inheriting the host's own `dir` attribute via `:dir()`, including live
  updates when an ancestor's `dir` changes after mount, and across the
  shadow-root boundary for the overflow-menu wrapper item.

Along the way, worked around two non-obvious base-class behaviors that
caused regressions mid-fix: `SpectrumElement` overrides `dir` to return
computed CSS direction rather than the attribute (must read
`getAttribute('dir')` for authored values), and CSS `:dir()` resolves
directionality via the attribute chain, independent of the `direction`
property.

Adds Storybook stories (`languageOfParts` / `LanguageOfParts`) and test
coverage for each fix, each verified to fail without its corresponding
code change.

Jira: SWC-2359

fix: refactor `dir` attribute normalization into a utility method

fix(combobox): use correct type shape

Co-Authored-By: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.git... (continued)

6112 of 6556 branches covered (93.23%)

Branch coverage included in aggregate %.

425 of 427 new or added lines in 8 files covered. (99.53%)

38557 of 39836 relevant lines covered (96.79%)

459.88 hits per line