accordproject / concerto / 33892722895

98%

push

github

fix(concerto-cto): preserve an empty string default (#1316)

The default value rules guarded with a plain truthiness check. The numeric
and boolean rules return the raw matched text, so that is safe for them, but
StringDefault returns the decoded value, and an empty string is falsy. A
field or scalar declared default="" therefore lost its default at parse
time, and the printer dropped it again for String, DateTime and Object while
the numeric and boolean cases already used explicit undefined checks.

concerto-core already supports falsy defaults: field.ts and
scalardeclaration.ts both guard with !Util.isNull(this.ast.defaultValue), so
feeding the AST directly yields "" correctly. Only the CTO front end lost
it, which also made the model unusable, since the field is then treated as
having no default and validation reports it as missing.

Fixture added covering a String property, a String scalar, default=""
combined with a length range, and a non-empty control; it exercises both the
parser and printer suites.

Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>

2201 of 2294 branches covered (95.95%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

4037 of 4076 relevant lines covered (99.04%)

129582.54 hits per line