hyperledger-labs / fabric-smart-client / 33890837802
85%

DEFAULT BRANCH: main
Ran
Jobs 21
Files 500
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.302% (-0.03%) from 85.332%
33890837802

push

github

web-flow 
docs(dev): align the dev guides with the Makefile and document the PR flow (#1725)

Add `go-fix` and `go-fix-apply` targets covering every module, fold the check
into `make checks`, and point the Go Fix Check workflow at it. Apply the two
fixes `integration/` had drifted by while the check ran on the root module
only.

Correct the stale targets, paths and snippets found across the developer and
agent guides: neither `integration.Opts` nor a top-level `sdk/dig/sdk.go`
exists, `make testing-docker-images` was never a real target, mocks regenerate
through `make generate-mocks` not `go generate ./...`, and the signature and
rebase-verification snippets did not run as written (`git log -n` needs a
count).

Document the branch flow contributors and agents are expected to follow: local
development with a draft PR opened early, squash to one meaningful message
before requesting review, fixup commits during review, autosquash once
approved; the Conventional Commits message format; how issues and PRs should
be described, including the finalize-required-but-otherwise-optional priority
label; how to register a new integration target (`INTEGRATION_DIR_*`,
`INTEGRATION_FLAGS_*`, `HSM_INTEGRATION_TARGETS`); and three traps that cost
real debugging time: `FABRIC_BINARY_BASE` resolving outside a worktree,
`gofmt -l` reporting gitignored generated output, and a zero-spec ginkgo run
reporting `ok` indistinguishably from a real pass. Close by stating the
convention this whole change follows: a change that leaves `docs/agents/` or
`docs/dev/` wrong is not finished.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

31299 of 36692 relevant lines covered (85.3%)

2795.1 hits per line

Coverage Regressions

Lines Coverage ∆ File
5
86.94
 0.0% platform/view/services/comm/host/websocket/ws/multiplexed_provider.go
4
87.5
 -6.25% platform/fabric/events.go
3
68.4
 -1.42% platform/view/services/comm/host/libp2p/host.go
2
87.91
 -1.1% platform/view/services/comm/session.go
2
91.96
 -0.6% platform/view/services/comm/p2p.go
2
54.55
 -18.18% platform/view/services/storage/driver/sql/sqlite/errormapper.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fabric-iou - 33890837802.1 458
41.61
 GitHub Action Run
2 itest-fabric-runtimeconfig - 33890837802.2 458
40.11
 GitHub Action Run
3 itest-fsc-pingpong - 33890837802.3 247
35.02
 GitHub Action Run
4 itest-fsc-stoprestart - 33890837802.4 243
33.93
 GitHub Action Run
5 itest-fabric-events - 33890837802.5 453
29.69
 GitHub Action Run
6 itest-fabric-configupdate - 33890837802.6 458
39.9
 GitHub Action Run
7 itest-fabric-iouhsm - 33890837802.7 458
40.76
 GitHub Action Run
8 itest-fabric-iou-libp2p - 33890837802.8 458
37.65
 GitHub Action Run
9 itest-fabric-twonets - 33890837802.9 448
29.81
 GitHub Action Run
10 itest-fabric-atsa - 33890837802.10 448
44.82
 GitHub Action Run
11 itest-fabricx-simple - 33890837802.11 478
28.86
 GitHub Action Run
12 utest - 33890837802.12 491
78.36
 GitHub Action Run
13 itest-fsc-signedpingpong - 33890837802.13 241
31.95
 GitHub Action Run
14 itest-fabricx-iou - 33890837802.14 478
30.36
 GitHub Action Run
15 itest-fabricx-configupdate - 33890837802.15 478
29.46
 GitHub Action Run
16 itest-fabricx-deployment - 33890837802.16 478
29.51
 GitHub Action Run
17 itest-fabric-atsachaincode - 33890837802.17 453
31.62
 GitHub Action Run
18 utest-postgres - 33890837802.18 491
10.0
 GitHub Action Run
19 itest-fabricx-atsa - 33890837802.19 478
31.69
 GitHub Action Run
20 itest-fabricx-multiendorsement - 33890837802.20 478
29.54
 GitHub Action Run
21 itest-fabric-stoprestart - 33890837802.21 448
31.82
 GitHub Action Run
Source Files on build 33890837802