solidjs / solid / 33850010698

72%

main: 89%

push

github

fix(signals): an optimistic store's first flight declares no transaction (#3264)

The flight-owned transaction (#3146) was declared for the uninitialized
first ask too, so every transition-riding consumer — render()'s scheduled
root insert included — was held until the initial fetch landed: the page
stayed blank (content outside the boundary included) and the Loading
boundary's fallback never showed, while createStore(fn, seed) and
createOptimistic(fn, seed) in the same spot showed it.

Nothing has committed on a first flight, so there is no truth to keep on
screen and no optimistic state to protect: it now declares nothing, like
the loading window (#2933). Refetch flights declare exactly as before, so
bare optimistic writes during an in-flight refetch still ride the flight's
transaction (#2951). Regressions in the #3146 suite (a user effect is what
reproduces the hold) and in the web Loading spec through render().

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

515 of 783 branches covered (65.77%)

Branch coverage included in aggregate %.

764 of 998 relevant lines covered (76.55%)

14.93 hits per line