solidjs / solid / 33849998807

72%

main: 89%

push

github

fix(signals): exempt the thenable probe from the store strict-read check (#3263)

Resolving a promise with a store proxy — refresh(store)'s waiter delivers
the store, Promise.resolve(store), `return store` from an async function —
makes the engine read `store.then` synchronously in the caller's scope. When
that scope carries a strict-read label (an effect callback, a component
body) the read produced a spurious STRICT_READ_UNTRACKED warning, and
against a refetching derived store it could escalate to the
PENDING_ASYNC_UNTRACKED_READ throw, rejecting the promise being resolved.
`await refresh(list)` inside an action logged the warning on every call.

The `then` probe is not a read the user wrote; it is now exempt from both.
Regressions live in the store strict-read suite.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

515 of 783 branches covered (65.77%)

Branch coverage included in aggregate %.

764 of 998 relevant lines covered (76.55%)

14.95 hits per line