valkyrjaio / valkyrja-java / 33829946958

100%

push

github

[Cli] feat(#203)!: Separate a provided parameter from one with a value (#204)

# Description

`ParameterContract::hasFirstValue()` reported that an input item is
attached to the parameter. The name reads as "the parameter has a
non-empty value", which is a different question, and a valueless flag
the caller passed returned `true`. `RouteContract::hasOption()` and
`hasArgument()` report that the route **declares** a parameter, and the
router keeps every declared parameter, so neither reports what the
caller passed. No method answered "did the caller pass this parameter",
and the two that looked like they did are the ones a command reaches
for.

`isProvided()` now reports that an input item is attached, with or
without a value. `hasFirstValue()` reports a first value that is not
empty. `RouteContract` gains six declarations that never throw, so a
command asks the question in one call. Java has no optional parameter,
so each value method carries a one-argument overload and a two-argument
one.

The commands read the parameters through the new methods, and the
`abstract_.Command` base that held the previous helpers is removed. The
contract methods supersede every helper it carried. `ListCommand` and
`HelpCommand` call `getOptionValue(name)`, and `ListBashCommand` calls
`getArgumentValue(name)`.

Closes #203

## The declared default

`getOptionValue()` falls back to the `defaultValue` the option declares,
and to an empty string where the option declares none. Before this
change the framework read `defaultValue` in one place only, the help
output, so a command that printed `` `json` (default) `` still handed
its author an empty string. Each author repeated the default at the call
site, and the help output and the behavior could drift apart.

A default passed to the method overrides the declared one, so the
parameter is `null` by default rather than `''`. That keeps "passed
nothing" apart from "passed an empty string".

`getArgumentValue()` gains the same pai... (continued)

1891 of 1891 branches covered (100.0%)

Branch coverage included in aggregate %.

38 of 38 new or added lines in 7 files covered. (100.0%)

6939 of 6939 relevant lines covered (100.0%)

4.32 hits per line