valkyrjaio / valkyrja-java / 33826959756

100%

push

github

[Cli] fix: Write CLI output to the configured file and stream (#177)

# Description

Write a CLI message to the filepath and to the stream the output holds.
`FileOutput` and `StreamOutput` overrode `outputMessage` with an empty
body, so
a command that directed its output to a file or to a stream lost every
message
and still reported success.

Each class now writes the formatted text the base class prints, and
wraps the
`IOException` a failed write raises in a component throwable.
`InputHandler`
routes a write throwable to the `ThrowableCaught` middleware, registers
the
recovery output in the container, and falls back to an output that
prints, so
the process still runs the exit middleware.

Every middleware stage the handler drives now runs under a guard,
because a
middleware that threw took the exit path with it. The read of the exit
code
carries a guard as well, because an output supplies that value. The code
the
output reports still reaches `Exiter.exit`.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`cli/interaction/output/FileOutput.java`** — appends the formatted
text to the filepath, and wraps a failed write
- **`cli/interaction/output/StreamOutput.java`** — writes the formatted
text to the stream, and wraps a failed write
- **`cli/interaction/throwable/exception/`** — adds the file write and
stream write throwables
- **`cli/server/handler/InputHandler.java`** — routes a write throwable
to the `ThrowableCaught` middleware, guards the dispatch in `handle` and
the `ProcessExiting` stage, and falls back to an output that prints
- **`cli/README.md`** — documents the write path, the thro... (continued)

1895 of 1895 branches covered (100.0%)

Branch coverage included in aggregate %.

77 of 77 new or added lines in 5 files covered. (100.0%)

6936 of 6936 relevant lines covered (100.0%)

4.32 hits per line