aas-core-works / aas-core-codegen / 33794539143

85%

push

github

Simplify XML de-serialization in C# (#672)

We refactor the C# XML de-serialization to remove duplicated
boilerplate, mirroring the TypeScript simplification (#671).

List-item parsing used to be one inline while-loop generated per
list-typed property. We introduce two shared generic helpers,
`ParseListOfClass<T>` and `ParseListOfStruct<T>` (split by reference-type
vs. value-type items, since C# 8 does not support unconstrained
nullable type parameters), and every list property now just calls the
matching helper with an item deserializer instead of duplicating the
loop.

Concrete-class-from-element parsing used to bundle the open-tag read,
the name check and the close-tag read inline in every generated
`{Cls}FromElement` function. We split this into two shared helpers,
`ReadStartElementOfClass` and `ConsumeCloseTag`, so the per-class
function only wires them together with its own class name and calls
`{Cls}FromSequence` in between.

Both refactors preserve the exact generated error messages where the
message did not depend on the removed context string, so no
externally observable behavior changes beyond that one message.

19 of 19 new or added lines in 1 file covered. (100.0%)

30901 of 36504 relevant lines covered (84.65%)

2.54 hits per line