aas-core-works / aas-core-codegen / 33789666198

85%

push

github

Simplify XML de-serialization in TypeScript (#671)

We refactor the TypeScript XML de-serialization to modularize both
the generator code and the code it generates.

Class parsing used to be one function per concrete class which read
its own opening tag, parsed its properties, and consumed its own
closing tag. We split this into a sequence parser (properties only,
stopping -- without consuming -- at the closing tag) and a single
shared `consumeCloseTag` helper which every caller (single-property
dispatch, list items, root dispatch, interface dispatch) now calls
itself. This removes the per-class open-tag wrapper that previously
existed only to bundle that one check, and lets every caller reject
an element of the wrong type based on its opening tag alone.

List item parsing is unified behind one generic `parseList<T>`
function instead of duplicating the same while-loop for every list
property in the meta-model.

Every polymorphic dispatch function also gets a public
`{Interface}FromXmlString` entry point, mirroring the existing JSON
de-serialization API, so that it has a real caller even
when the interface happens not to be used as the type of any
property.

93 of 96 new or added lines in 2 files covered. (96.88%)

30883 of 36486 relevant lines covered (84.64%)

2.54 hits per line