source-academy / py-slang / 33771791102

86%

push

github

Fix EvaluatorError dropping line/column for BaseResolverError-shaped errors (#441)

EvaluatorError (conductor/errors.ts) only read a source error's location from
error.location.start.{line,column} - the shape RuntimeSourceError (implements
SourceError) uses. But BaseResolverError (resolver/errors.ts), used for
NameNotFoundError, NameReassignmentError, etc., extends the native SyntaxError
and carries flat line/col instead. Neither shape overlaps, so every resolver
error's line/column was silently dropped when wrapped for conductor.sendError,
regardless of frontend's own prepend-line-offset correction downstream
(source-academy/frontend#4244) - there was never a number for it to shift,
since EvaluatorError.line was always undefined for this error class.

Fall back to the flat line/col shape when location.start isn't present.


Claude-Session: https://claude.ai/code/session_01FYm9pttcp3nixtDLKiPh2k

Co-authored-by: Shrey Jain <“shreyjain5132@email.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Martin Henz <henz@nus.edu.sg>

4892 of 6131 branches covered (79.79%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

10920 of 12308 relevant lines covered (88.72%)

162109.57 hits per line