rero / rero-ils / 33765034690
92%

DEFAULT BRANCH: staging
Ran
Jobs 1
Files 614
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.535% (+0.09%) from 91.446%
33765034690

push

github

jma 
refactor: remove legacy scripts and dead code

Nothing here has a caller left. Most of it lost its last one when
the dead options of `scripts/setup` went, in the previous commit.

* `load_virtua_transactions`, with its two private helpers, loaded
  circulation transactions exported from Virtua
* `create_operation_logs` was named `migrate_virtua_operation_logs`
  until 2021; it read the same export
* `dump_operation_logs`, its counterpart, wrote `str(record)` into a
  `JsonWriter`, so its output was a JSON array of Python reprs that
  nothing could read back
* `check_pid_dependencies` and its two data files were only ever
  driven by `create_csvs -p`
* `dump_search_mappings` was only ever driven by `setup
  --es-mapping`
* `create_csvs` asks for the `cont` pid type, renamed `rement` long
  ago, and for a command no longer registered
* `dojson_virtua` calls a dojson rule that does not exist
* `create_request` lost its caller in June 2022, when `create_loans`
  started routing every request type through `create_loan`
* the eight data files they read

Two manual tools go with them. Neither is called by anything, and
neither has had a substantive change in five years:
`all_year_days` replayed a command for every day of the year under
faketime, and `load_testing.py` hammered the REST API.

`scripts/console` goes too, for a different reason: it had a caller
but nothing to do. Twenty-three lines, `set -e` written twice, and
one command. The poe task runs `invenio shell` directly, as
`format`, `lint` and `tests` already do; `uv run poe console` is
unchanged for the caller.

`convert_marc21xml.py` stays, and says why. Its name promised a
general MARC21 converter, so it read as misplaced among the shell
scripts. It is the converter of the `cogne` fixture: the production
ones live in the private `rero-ils-migrations`, which cannot be a
dependency here, and it pairs that package's MARC21 conversion with
the `dedup` that package leaves abstract. It is outside `rero... (continued)

24383 of 26638 relevant lines covered (91.53%)

0.92 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33765034690.1 614
91.53
GitHub Action Run
Source Files on build 33765034690