steinfletcher / apitest / 33756597152

100%

push

github

Raise test coverage (#176)

* Remove error checks that cannot fire and dead code

- createHash checked the error from hash.Hash.Write, which is
  documented never to fail.
- messageFromMsgAndArgs had an unreachable trailing return.
- The sequence diagram template is parsed once at package init and
  executed directly into the output file, and formatBodyContent no
  longer checks errors from json.Indent on JSON that json.Valid
  accepted or from bytes.Buffer.Write, neither of which can fail.
- DumpRequest and DumpResponse cannot fail when the body is not
  dumped, so the log entry builders no longer check them.
- difflib's SetSeq1/SetSeq2 compared the address of a parameter with
  the address of a field, which is never equal.

No behaviour changes.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* Cover the remaining code paths with tests

Adds tests for DefaultVerifier and NoopVerifier, the diff helper,
request builder failure paths (multipart writer and file read errors,
immediate failures once Expect has been called), Result.JSON errors,
mock builders and matchers (BodyRegexp, body and form data error
paths, deep copies, standalone mocks with a client and debug),
transport debug output, recorder hooks, networking and handler
failures, header presence failures, sequence diagram formatting
errors and the OS file system, every x/db driver interface
combination and error path, and difflib's junk handling, autojunk,
writer errors and colour switch.

Coverage: apitest 99.8%, difflib 100%, mocks 100%, x/db 100%. The two
remaining lines are guards in callerInfo for frames the runtime never
reports.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

25 of 25 new or added lines in 3 files covered. (100.0%)

2652 of 2654 relevant lines covered (99.92%)

76.63 hits per line