hyperledger / fabric-x-committer / 33737353773

90%

main: 90%

Build Type

Pull #744

github

Committed by liran-funaro

Commit Message

[sidecar] Report each notification stream's block queue

#### Type of change

- New feature

#### Description

- Report each `StreamAllTransactions` subscription's block queue as
  `sidecar_notifier_stream_block_queue_size`, one series per live stream, through
  `monitoring.ChannelLenGaugeVec`. A subscription's queue exists per stream, so a gauge closing
  over a single channel cannot address it.
- Register and unregister alongside the stream, in `registerAllTxStream` and
  `unregisterAllTxStream`, so a finished subscription leaves no series reporting the depth of a
  queue nothing drains.

#### Additional details (Optional)

The `stream` label is a counter, unique only among the live streams, which is all it needs to be
since a series exists only while its stream does. Cardinality therefore follows the number of live
subscriptions rather than growing over time.

Read it with `sum()` for the total or `max()` to catch one saturated stream; `sum` covers only the
live streams.

#### Related issues

- resolves #734
- related to #730

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #744: [sidecar] Report each notification stream's block queue

Coverage Stats

85 of 85 new or added lines in 5 files covered. (100.0%)

22 existing lines in 6 files now uncovered.

9385 of 10379 relevant lines covered (90.42%)

11638.91 hits per line