hyperledger / fabric-x-committer / 33737351482

90%

main: 90%

Build Type

Pull #737

github

Committed by liran-funaro

Commit Message

[verifier] Report the per-stream executor queues

#### Type of change

- New feature

#### Description

- Add `monitoring.ChannelLenGaugeVec[T]`, a collector for a queue that exists once per stream or
  worker. `Register`/`Unregister` add and remove a channel and `Collect` reads each live one, so
  cardinality follows the number of live streams and a finished stream leaves no series behind.
  Re-registering the same label values replaces the channel, since prometheus rejects a duplicate
  series mid-scrape.
- Report the verifier's three `parallelExecutor` queues through it, one series per stream. A new
  executor exists per stream, so a gauge closing over a single channel cannot address them.
  `StartStream` registers them when it creates the executor and unregisters them on return.

#### Additional details (Optional)

`prometheus` has no `GaugeFuncVec`, which is why this is a custom `Collector` rather than another
wrapper over `NewGaugeFunc`. The `stream` label is a counter, unique only among the live streams,
which is all it needs to be since a series exists only while its stream does.

Read these with `sum()` for the total across streams or `max()` to catch one saturated worker
while the total still looks healthy; `sum` covers only the live streams.

#### Related issues

- resolves partly #734
- related to #730

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #737: [verifier] Report the per-stream executor queues

Coverage Stats

72 of 72 new or added lines in 3 files covered. (100.0%)

6 existing lines in 3 files now uncovered.

9393 of 10366 relevant lines covered (90.61%)

12050.52 hits per line