hyperledger-labs / fabric-smart-client / 33736099224

86%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): validate discovered peer identities against the channel's MSPs (#1703)

A discovery response is supplied by whichever peer answered the query. The
envelope signature checks made while parsing it prove only that each envelope was
signed by the key in the identity shipped alongside it, which a malicious
responder satisfies with an identity no CA ever issued - and the TLS roots that
would authenticate the peer came from that same response.

Validate every peer at toDiscoveredPeers, the one point where a discovery
response becomes a driver.DiscoveredPeer: deserialize and validate the identity
against the channel configuration's MSPs, cross-check the MSP ID the response
claimed against the identity's own, and take TLS roots from the channel
configuration instead. An unrecognized peer is dropped so that one rogue entry
cannot deny service - except where the request cannot be satisfied without it,
so an implicit collection left with no endorsers is reported and names the
organization.

The channel configuration arrives asynchronously, so Service.WithConfigWait
gives the chaincode manager a view whose reading accessors wait for the first one
instead of failing for that window, reusing ChannelConfig.DiscoveryTimeout() as
the budget. The committer keeps the non-waiting view: it installs the
configuration and must not wait on it. deferred.Holder gains WaitForValue for
this, releasing parked callers on a value, a refusal or a reset, so an
unavailable or refused configuration is always reported as such and never as
peers failing validation.

MembershipConstructor now returns *membership.Service instead of
driver.MembershipService, which makes the trust anchor discovery needs a
compile-time requirement.

Closes #1623.

Signed-off-by: Said Altury <Said.Altury@ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Co-authored-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

166 of 174 new or added lines in 5 files covered. (95.4%)

10 existing lines in 4 files now uncovered.

31471 of 37138 relevant lines covered (84.74%)

3293.23 hits per line