PHPOffice / PHPPresentation / 33716696556

94%

push

github

PowerPoint2007 Reader : Give a shadow its colour, its alpha and its alignment, and a shape its wrap (#982)

* PowerPoint2007 Reader : Give a shadow its colour, its alpha and its alignment, and a shape its wrap

`loadShadow()` read `algn` off `$node`, the `a:effectLst`, instead of off the `a:outerShdw` inside
it, so a shadow's alignment always came back empty. The same method looked for the colour under
`a:prstClr` only, while the Writer writes it as `a:srgbClr` with the shadow's alpha as the
`a:alpha` inside it, so neither the colour nor the alpha was ever read. Both spellings are read
now, and the alpha goes to the shadow rather than to the colour, which is where the Writer takes it
from.

`wrap` is written on `a:bodyPr` beside the insets and the two other attributes the Reader takes
from there, and nothing read it back. `none` and `square` are the two values a shape's wrap holds,
spelled the same way in the file.

`hasColumnsRTL()` is left as it is: `null` means nobody said, and the Writer always writes
`rtlCol`, so a file cannot say nothing.

* PowerPoint2007 Reader : Let a shadow's colour carry the alpha the file gives it

A shadow says how see-through it is twice over: on its own `alpha`, and in the two
characters in front of its colour. The file has room for one of them, the `a:alpha`
inside `a:srgbClr`, and it is the shadow's own that the Writer puts there.

Reading it back built the colour by hand and gave it no alpha at all, so every shadow
came back with an opaque colour whatever the file said. `loadStyleColor()` in the same
Reader already reads a colour together with its `a:alpha`; using it leaves one place
where that is done, and the shadow takes its own alpha from the colour it just read.

The round-trip test now runs over three pairs of colour and shadow alpha, so the case
where the alpha is something other than `FF` is covered rather than assumed.

9 of 10 new or added lines in 1 file covered. (90.0%)

11310 of 12024 relevant lines covered (94.06%)

70.95 hits per line