PHPOffice / PHPPresentation / 33645469827

94%

push

github

ODPresentation Writer : Share the graphic and the drawing-page styles too (#936)

* ODPresentation Writer : Share the graphic and the drawing-page styles too

The style pool named the paragraph and the text families. The graphic family
and the drawing-page family kept naming a style after the position of the thing
wearing it -- `gr` plus the shape counter, `stylePage` plus the slide index --
so a document could not share one however alike two shapes were. Ten default
slides holding eight identically formatted shapes and a line wrote 90 graphic
and 10 drawing-page definitions for three distinct styles.

Name them out of the pool as well, on the prefixes LibreOffice uses for the two
families. Every reference in that document resolves to the same style body as
before, and `content.xml` goes from 57 591 to 32 184 bytes.

The two passes no longer have to count in step to agree on those names, which
is what a positional name required and what the shape counter was reset and
re-incremented for. It stays only for the chart objects, which are addressed by
it.

The table families keep their positional names: nothing reads a `table:table`
back, so no round trip holds a renaming of theirs to anything.

* ODPresentation Writer : Say shapes where the loop walks shapes

Both comments read `// Images` over a loop that walks the whole shape collection, and has since
long before either of them was written.

264 of 270 new or added lines in 1 file covered. (97.78%)

11302 of 12022 relevant lines covered (94.01%)

70.2 hits per line