iotaledger / iota / 33703404334

70%

Build Type

push

github

Committed by web-flow

Commit Message

feat(iota-types): add DynamicFieldNotExists error for missing dynamic fields (#12820)

# Description of change

Return a dedicated error when a dynamic field does not exist, instead of
the generic read error.

`get_dynamic_field_object_from_store` returned
`IotaError::DynamicFieldRead` both when reading a field failed and when
the field simply was not there, so a caller could not tell a missing
field apart from a real read failure without parsing the message text.

This PR:

- adds the `IotaError::DynamicFieldNotExists { parent_id, id, key }`
variant and returns it from `get_dynamic_field_object_from_store` when
the derived field object is absent from the store; failed reads keep
returning `DynamicFieldRead`,
- appends the variant at the end of `IotaError`, per the append-only
rule; the variant-order snapshot from #12819 (which this PR is stacked
on) picks it up as a one-line diff in `tests/staged/iota_error.yaml`,
- adds a unit test asserting the missing-field case yields
`DynamicFieldNotExists` with the parent and key, and that the same
lookup succeeds once the field object is present.

Checked that nothing matches on `DynamicFieldRead` or parses its message
text, with a positive control per method: a full-filetype grep (sources,
snapshots, fixtures) over this repo, `iota-rust-sdk`, `ts-packages`,
`wasp`, `identity`, and `network-benchmark`, validated by planting the
needle in each repo and confirming the same command finds it; and an
org-wide GitHub code search, validated on a string that is known to be
referenced across repos. The only hits are the definition and
construction sites in this repo - no match arms, no message-text parsing
- so narrowing `DynamicFieldRead`'s use is not observable by existing
consumers.

## Links to any relevant issues

None.

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added ... (continued)

Coverage Stats

17 of 18 new or added lines in 1 file covered. (94.44%)

907 existing lines in 29 files now uncovered.

177449 of 252206 relevant lines covered (70.36%)

445969.73 hits per line