radio-t / stream-recorder / 33693251518

77%

master: 76%

Build Type

Pull #33

github

Committed by paskal

Commit Message

Bound post-recording processing with a context

Both post-recording passes rewrite the whole file, and neither could be
interrupted. id3.InjectFrames copies with io.CopyN and io.Copy, and
FixVBRHeader ran ffmpeg through exec.Command with no context, while
wg.Wait blocks process exit until they finish. A stalled disk or a hung
ffmpeg therefore held up SIGINT and SIGTERM indefinitely.

InjectFramesContext and FixVBRHeaderContext take a context: the copy
aborts between reads, and a cancelled remux kills ffmpeg and removes its
temporary output. The exported InjectFrames and FixVBRHeader stay as
wrappers over context.Background.

tryInjectMetadata runs both under a fresh context with a five minute
deadline. It stays independent of the recording context, so finalising
still happens after shutdown was requested, which is when a recording
usually ends, but it can no longer run without limit.

Pull Request Pull Request #33: Bound post-recording processing with a context

Coverage Stats

24 of 30 new or added lines in 3 files covered. (80.0%)

2 existing lines in 1 file now uncovered.

1025 of 1336 relevant lines covered (76.72%)

8.33 hits per line