archetech / archon / 33682434220

87%

push

github

Move the remaining eight packages to Express 5 (#1024)

* fix(services): Drop the wildcard OPTIONS route from gatekeeper and keymaster

Both services registered `app.options('*', cors())` directly after
`app.use(cors())`. The route never ran: cors() handles OPTIONS itself,
setting the preflight headers and ending the response rather than calling
next(), since preflightContinue defaults to false. Requests were answered
by the app.use above and never reached it.

Express 5 moved to path-to-regexp v8, which rejects a bare '*' as a path,
so the server threw before it could listen. That is the
`container archon-gatekeeper-1 is unhealthy` failure on the pending
express bumps, and none of the eleven packages already on Express 5
contains this call.

Removing it changes nothing on Express 4, verified against the service's
own express 4.21.2 and cors 2.8.5: an app with only app.use(cors()) and no
wildcard route answers preflight with 204 and the full header set.

CORS had no test, which is part of why an unreachable route survived. The
new one asserts preflight against the real app and fails if the cors
middleware is removed.

This clears the one confirmed blocker in two of the eight packages still
on Express 4. It does not migrate them: no version moves here, and the
remaining six are unaudited.

Refs #1023.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* feat(services): Move the remaining eight packages to Express 5

Eleven packages already ran Express 5 while eight stayed on 4.x, so two
majors of the same framework shipped side by side with nothing recording
that as a decision. This moves the rest to ^5.2.1.

The only code incompatibility was the wildcard OPTIONS route removed in the
previous commit. An audit of all eight found no other affected usage: no
wildcard or optional route paths, no req.param, app.del, res.send(status),
res.json(obj, status), res.sendfile, redirect('b... (continued)

3881 of 4464 branches covered (86.94%)

Branch coverage included in aggregate %.

8528 of 8953 relevant lines covered (95.25%)

717.59 hits per line