bleedingdeacons / link / 33670352487
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 11
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.454% (+0.04%) from 84.41%
33670352487

push

github

web-flow 
fix: redraw the message list when a push arrives (#4)

* fix: remove a tab icon that was never added

The Messages tab referenced ic_message.png, which does not exist under
Resources/Images and never did. Android resolved it to nothing and
rendered the tab without an icon, so the tab bar looked deliberate —
Settings has no icon either — while Glide logged a FileNotFoundException
on every render. Found in logcat while verifying a sign-in, not from
anything visible on screen.

Removed rather than replaced: two text labels read perfectly well, and
adding artwork for one tab and not the other would be worse than none.
Icons are a design decision for both tabs together, if they are wanted.

* fix: redraw the message list when a push arrives

A pushed message was stored and a notification raised, but the list on
screen went on showing what it loaded when the page appeared. Seen on a
real handset: notification posted, message in the history, list still
reading 'No messages yet' until the page was navigated away from and
back. Wrong in exactly the case that matters most — somebody looking at
the list when something arrives.

ReceivePushAsync now announces through WeakReferenceMessenger after the
save, so a subscriber that reloads finds the message there. The view
model hops to the UI thread before touching its ObservableCollection,
since the announcement arrives on whichever thread the push service
used; IUiDispatcher already existed for exactly this.

Only push announces. A sync is started by the UI and reloads when it
finishes, so announcing that too would redraw twice for one action.

603 of 714 relevant lines covered (84.45%)

6.25 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
96.55
0.04% Services/MessageService.cs
Jobs
ID Job ID Ran Files Coverage
1 33670352487.1 11
84.45
GitHub Action Run
Source Files on build 33670352487