coreui / coreui-pro / 33666954908

94%

main: 94%

push

github

refactor(scss): split the validation mixins into mixins/ and forms/ (#1056)

`scss/mixins/_forms.scss` held everything validation: the feedback variables,
the states map, the tokens, the selector mixin and the 200-line
`form-validation-state` mixin that writes the rules. Upstream keeps the two
apart — `mixins/_form-validation.scss` for the selector mixin, and
`forms/_validation.scss` for the mixin that emits the rules plus the loop — so
every change of theirs in that area landed in a file of ours that mostly did
not carry the code, and each diff cost more than it had to.

Now `mixins/_form-validation.scss` holds what produces no rules — the feedback
and tooltip variables, the states map, the icon geometry, the tokens and
`form-validation-state-selector` — and `forms/_validation.scss` holds what
does: `form-control-group-validation-state`, `form-validation-state` and the
loop.

Keeping the variables and the map in the mixin file is deliberate rather than
upstream's placement: `_input-group.scss` reads the states map to build its
feedback exclusion list and `_form-control.scss` reads the icon geometry, and
both load before validation. Pointing them at a rule-bearing module would pull
its `@layer forms` block forward by 1300 lines and silently reorder the cascade
inside that layer.

The docs cite the two mixins separately now, under upstream's capture names.
`form-control-group-validation-state` drops out of the quoted block, which the
page's own "Two mixins are combined together" already claimed.

All five compiled entry points are byte-identical.

4830 of 5430 branches covered (88.95%)

Branch coverage included in aggregate %.

9263 of 9687 relevant lines covered (95.62%)

399.62 hits per line